[8u-dev] Request for REVIEW and APPROVAL to backport: 8149330: Capacity of StringBuilder should not get close to Integer.MAX_VALUE unless necessary

Martin Buchholz martinrb at google.com
Wed Mar 2 20:20:04 UTC 2016


Reviewed!

On Wed, Mar 2, 2016 at 9:29 AM, Ivan Gerasimov
<ivan.gerasimov at oracle.com> wrote:
> Hello!
>
> I'm seeking for approval to backport this fix into jdk8u-dev.
> Comparing to Jdk9, the patch had to be changed mainly due to compact string
> support introduced in jdk9.
> However, the fix is essentially the same: we just avoid getting too close to
> Integer.MAX_VALUE when doing reallocations unless explicitly required.
>
> Would you please help review it?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8149330
> Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/123593aacb48
> Jdk9 review:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-February/039018.html
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-March/039182.html
> Jdk8 webrev: http://cr.openjdk.java.net/~igerasim/8149330/04/webrev/
>
> Sincerely yours,
> Ivan



More information about the core-libs-dev mailing list