RFR 8150679: closed/javax/crypto/CryptoPermission/CallerIdentification.sh fails after fix for JDK-8132734

Claes Redestad claes.redestad at oracle.com
Thu Mar 3 15:00:20 UTC 2016


Hi,

On 2016-03-03 12:26, Paul Sandoz wrote:
>> On 2 Mar 2016, at 20:12, Steve Drach <steve.drach at oracle.com> wrote:
>>
>> Please review the following fix for JDK-8150679
>>
>> webrev: http://cr.openjdk.java.net/~sdrach/8150679/webrev/ <http://cr.openjdk.java.net/~sdrach/8150679/webrev/>

Looks OK to me.
>> issue: https://bugs.openjdk.java.net/browse/JDK-8150679 <https://bugs.openjdk.java.net/browse/JDK-8150679>
>>
>> The test was modified to demonstrate the problem.
> You are essentially bombing out of MR-JAR functionality if the JarEntry is not an instance of JarFileEntry. That might be ok for a short-term solution, but it might require some further deeper investigation on things that extend JarEntry and how it is is used by VerifierStream [*].

I agree with Paul that this needs deeper investigation as a follow-up, 
but would like to stress that this fix addresses numerous things that is 
breaking in 9-b108, including many benchmarks. With a number of critical 
integrations planned in the next couple of weeks I think we need to 
fast-track a promotion with this fix before that happens so that we can 
provide reasonable testing.

Thanks!

/Claes



More information about the core-libs-dev mailing list