Review request for JDK-8151063 : Typo in java.lang.invoke.StringConcatFactory

Roger Riggs Roger.Riggs at Oracle.com
Fri Mar 11 14:15:54 UTC 2016


Hi Abhijit,

Reviewed (and I can sponsor to get it pushed if needed.)

Roger


On 3/11/2016 4:29 AM, Pavel Rappo wrote:
> Hi Abhijit,
>
> Looks good. (I'm not a Reviewer though.)
> I recommend you to create bugs on issues like this one (and [1]) trying to put
> as many typos per issue as possible. Also grouping typos by components. The
> reason is simple: separate bugs with current level of granularity and importance
> may produce too much noise. Thanks.
>
> P.S. Use Nagle's algorithm :-)
>
> ------------------------------------------------------------------------
> [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-March/039429.html
>   
>> On 11 Mar 2016, at 08:33, Abhijit Roy <abhijit.r.roy at oracle.com> wrote:
>>
>> Hi all,
>>
>>
>>
>> Please review a fix for Bug  - https://bugs.openjdk.java.net/browse/JDK-8151063
>>
>>
>>
>> Bug - Typo in java.lang.invoke.StringConcatFactory
>>
>>
>>
>> Webrev - http://cr.openjdk.java.net/~rpatil/abhi/8151063/webrev.00/
>>
>>
>>
>> I have rectified error and updated that one. And moving forward it for review.
>>
>>
>>
>>
>>
>> Regards,
>>
>> Abhijit.
>>
>>
>>
>>




More information about the core-libs-dev mailing list