RFR: 8059169 [Findbugs]Classes under package com.sun.tools.internal.xjc may expose internal representation by storing an externally mutable object

Wed Mar 16 11:51:52 UTC 2016

Hi Eric,
Thank you for fixing that.
Just for the record, I want to mention that this bug was also fixed by 
Eric in standalone JAXB project and it won't be erased during the next 
JAXWS sync-up process.

With Best Regards,
Aleksej

On 03/16/2016 10:48 AM, Eric Guo wrote:
> Hi Lance,
>
> Does it need 2 reviewer's approval for this webrev before code 
> submission?
>
> If yes, who can act as the another reviewer and help me to review it?
>
> Best Regards,
> Eric
>
> On 3/10/16, 3:24 AM, Lance Andersen wrote:
>> Looks OK Eric
>>
>> Best
>> Lance
>> On Mar 8, 2016, at 8:40 PM, Eric Guo <shihua.guo at oracle.com 
>> <mailto:shihua.guo at oracle.com>> wrote:
>>
>>> Hi Lance,
>>>
>>> Could you please help me to review these change?
>>> Thanks in advance!
>>>
>>> Best Regards,
>>> Eric
>>>
>>> -------- Original Message --------
>>> Received:     from userv0021.oracle.com 
>>> <http://userv0021.oracle.com> (/156.151.31.71) by default (Oracle 
>>> Beehive Gateway v4.0) with ESMTP ; Wed, 02 Mar 2016 22:28:35 -0800
>>> Received:     from ucsinet41.oracle.com 
>>> <http://ucsinet41.oracle.com> (ucsinet41.oracle.com 
>>> <http://ucsinet41.oracle.com> [156.151.31.69]) by 
>>> userv0021.oracle.com <http://userv0021.oracle.com> (8.13.8/8.13.8) 
>>> with ESMTP id u236SVHg004271 (version=TLSv1/SSLv3 
>>> cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 3 Mar 2016 
>>> 06:28:31 GMT
>>> Received:     from aojmv0009 (unknown [137.254.59.6]) by 
>>> ucsinet41.oracle.com <http://ucsinet41.oracle.com> with smtp id 
>>> 4204_0466_e2a7fa6b_d482_419c_ab4f_f8f9fec0737a; Thu, 03 Mar 2016 
>>> 06:28:30 +0000
>>> Received:     from aojmv0009.oracle.com 
>>> <http://aojmv0009.oracle.com> (localhost [127.0.0.1]) by aojmv0009 
>>> (Postfix) with ESMTP id 9658B16F609; Thu, 3 Mar 2016 06:28:25 +0000 
>>> (UTC)
>>> X-Original-To:     core-libs-dev at openjdk.java.net
>>> Delivered-To:     core-libs-dev at openjdk.java.net
>>> Received:     from ucsinet40.oracle.com 
>>> <http://ucsinet40.oracle.com> (ucsinet40.oracle.com 
>>> <http://ucsinet40.oracle.com> [156.151.31.68]) by aojmv0009 
>>> (Postfix) with ESMTP id C58E616F5EF for 
>>> <core-libs-dev at openjdk.java.net>; Thu, 3 Mar 2016 06:28:23 +0000 (UTC)
>>> Received:     from aserp1040.oracle.com 
>>> <http://aserp1040.oracle.com> (unknown [141.146.126.69]) by 
>>> ucsinet40.oracle.com <http://ucsinet40.oracle.com> with smtp (TLS: 
>>> TLSv1/SSLv3,256bits,ECDHE-RSA-AES256-GCM-SHA384) id 
>>> 13ae_0a81_00a41f18_5436_4604_a9e5_caacbe00a88d; Thu, 03 Mar 2016 
>>> 06:28:22 +0000
>>> Received:     from userv0021.oracle.com 
>>> <http://userv0021.oracle.com> (userv0021.oracle.com 
>>> <http://userv0021.oracle.com> [156.151.31.71]) by 
>>> aserp1040.oracle.com <http://aserp1040.oracle.com> 
>>> (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u236SMiV007844 
>>> (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for 
>>> <core-libs-dev at openjdk.java.net>; Thu, 3 Mar 2016 06:28:22 GMT
>>> Received:     from userv0121.oracle.com 
>>> <http://userv0121.oracle.com> (userv0121.oracle.com 
>>> <http://userv0121.oracle.com> [156.151.31.72]) by 
>>> userv0021.oracle.com <http://userv0021.oracle.com> (8.13.8/8.13.8) 
>>> with ESMTP id u236SM2j004060 (version=TLSv1/SSLv3 
>>> cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for 
>>> <core-libs-dev at openjdk.java.net>; Thu, 3 Mar 2016 06:28:22 GMT
>>> Received:     from abhmp0019.oracle.com 
>>> <http://abhmp0019.oracle.com> (abhmp0019.oracle.com 
>>> <http://abhmp0019.oracle.com> [141.146.116.25]) by 
>>> userv0121.oracle.com <http://userv0121.oracle.com> (8.13.8/8.13.8) 
>>> with ESMTP id u236SLNY005078 for <core-libs-dev at openjdk.java.net>; 
>>> Thu, 3 Mar 2016 06:28:21 GMT
>>> Received:     from [10.182.54.168] (/10.182.54.168) by default 
>>> (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 02 Mar 2016 22:28:21 
>>> -0800
>>> Message-ID:     <56D7D9C6.20704 at oracle.com>
>>> Date:     Thu, 03 Mar 2016 14:29:26 +0800
>>> From:     Eric Guo <shihua.guo at oracle.com>
>>> Organization:     Oracle Corporation
>>> User-Agent:     Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; 
>>> rv:10.0.6esrpre) Gecko/20120713 Thunderbird/10.0.6
>>> MIME-Version:     1.0
>>> To:     core-libs-dev at openjdk.java.net
>>> Subject:     RFR: 8059169 [Findbugs]Classes under package 
>>> com.sun.tools.internal.xjc may expose internal representation by 
>>> storing an externally mutable object
>>> References:     <56D7CE5C.2070607 at oracle.com>
>>> In-Reply-To:     <56D7CE5C.2070607 at oracle.com>
>>> X-Forwarded-Message-Id: <56D7CE5C.2070607 at oracle.com>
>>> Content-Type:     text/plain; charset=UTF-8; format=flowed
>>> Content-Transfer-Encoding:     7bit
>>> X-Source-IP:     userv0021.oracle.com <http://userv0021.oracle.com> 
>>> [156.151.31.71]
>>> X-BeenThere:     core-libs-dev at openjdk.java.net
>>> X-Mailman-Version:     2.1.17
>>> Precedence:     list
>>> List-Id:     Technical discussion about the development of the core 
>>> libraries <core-libs-dev.openjdk.java.net 
>>> <http://core-libs-dev.openjdk.java.net>>
>>> List-Unsubscribe: 
>>> <http://mail.openjdk.java.net/mailman/options/core-libs-dev>, 
>>> <mailto:core-libs-dev-request at openjdk.java.net?subject=unsubscribe>
>>> List-Archive: <http://mail.openjdk.java.net/pipermail/core-libs-dev/>
>>> List-Post:     <mailto:core-libs-dev at openjdk.java.net>
>>> List-Help: <mailto:core-libs-dev-request at openjdk.java.net?subject=help>
>>> List-Subscribe: 
>>> <http://mail.openjdk.java.net/mailman/listinfo/core-libs-dev>, 
>>> <mailto:core-libs-dev-request at openjdk.java.net?subject=subscribe>
>>> Errors-To:     core-libs-dev-bounces at openjdk.java.net
>>> Sender:     "core-libs-dev" <core-libs-dev-bounces at openjdk.java.net>
>>>
>>>
>>>
>>> Hi all,
>>>
>>> Could you please help me to review my code change about issue
>>> https://bugs.openjdk.java.net/browse/JDK-8059169  ?
>>>
>>> webrev:http://cr.openjdk.java.net/~fyuan/eguo/8059169/webrev.00/ .
>>> These change are only for JDK 9.
>>>
>>> Best regards,
>>> Eric
>>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif> 
>>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>
>>
>>