RFR: regex changes
Roger Riggs
Roger.Riggs at Oracle.com
Tue Mar 22 19:48:44 UTC 2016
Hi Sherman,
A few more comments,
Pattern.java:
- 1782: typo: "deterministci"
- 2176: commented out code?
- 2667: indentation
- 5660,5655: lambda syntax use of simply "ch" is preferred over
"(ch)" for single parameter lambdas
and for consistency within the file.
PrintPattern.java needs the standard copyright text if it is going to be
in the repo.
- 29: The Print(fmt, args...) method should follow the method naming
convention. (initial lowercase)
IntHashSet: does performance matter enough to warrant adding this extra
code.
Roger
On 3/18/2016 4:05 PM, Xueming Shen wrote:
> Hi,
>
> There are couple regex related changes waiting for review. I have pull
> them
> together here (with the notes) to make it easy to review.
>
> http://cr.openjdk.java.net/~sherman/regexBackTrack.Lamnda.CanonEQ/webrev/
>
> (1) Exponential backtracking
>
> Note:
> http://cr.openjdk.java.net/~sherman/regexBackTrack.Lamnda.CanonEQ/backtracking
>
> https://bugs.openjdk.java.net/browse/JDK-6328855
> https://bugs.openjdk.java.net/browse/JDK-6192895
> https://bugs.openjdk.java.net/browse/JDK-6345469
> https://bugs.openjdk.java.net/browse/JDK-6988218
> https://bugs.openjdk.java.net/browse/JDK-6693451
> https://bugs.openjdk.java.net/browse/JDK-7006761
> https://bugs.openjdk.java.net/browse/JDK-8140212
>
> (2) Anonymous class to lambda function cleanup
>
> Note:
> http://cr.openjdk.java.net/~sherman/regexBackTrack.Lamnda.CanonEQ/lambdafunction
>
> https://bugs.openjdk.java.net/browse/JDK-8151481
> https://bugs.openjdk.java.net/browse/JDK-6609854
>
> (3) Canonical Equivalents
>
> Note:
> http://cr.openjdk.java.net/~sherman/regexBackTrack.Lamnda.CanonEQ/canonEQ
>
> https://bugs.openjdk.java.net/browse/JDK-4916384
> https://bugs.openjdk.java.net/browse/JDK-4867170
> https://bugs.openjdk.java.net/browse/JDK-6995635
> https://bugs.openjdk.java.net/browse/JDK-6728861
> https://bugs.openjdk.java.net/browse/JDK-6736245
> https://bugs.openjdk.java.net/browse/JDK-7080302
>
> Thanks
> Sherman
More information about the core-libs-dev
mailing list