Review request for 8151571: System/LoggerFinder tests fail after JDK-8149925
Chris Hegarty
chris.hegarty at oracle.com
Wed Mar 23 13:15:54 UTC 2016
Hi Mandy,
On 22/03/16 18:41, Mandy Chung wrote:
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8151571/webrev.00/
I think this is fine. ( I also agree with Alan's comment )
Just a few minor, subjective, comments:
- Maybe update the CleanerFactory class-level docs,
OpenJDK modules -> system modules.
- CleanerFactory.cleaner
I find the paragraph a little confusing. Maybe something like:
* <p> This Cleaner will run on a thread whose context class loader
* is {@code null}. The ( system ) cleaning action should be robust
* enough to handle a {@code null} context class loader.
-Chris
More information about the core-libs-dev
mailing list