Code Review Request, 8152237 Support BigInteger.TWO

Roger Riggs Roger.Riggs at Oracle.com
Wed Mar 23 14:03:14 UTC 2016


Hi,

How much is the performance improvement?
I see that BigInteger.valueOf (n <= 16) have predefined constants and 
returns an existing instance.

Adding TWO is ok.

Roger

On 3/23/2016 9:44 AM, Wang Weijun wrote:
>> On Mar 23, 2016, at 7:23 PM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
>>
>> On 3/23/2016 5:44 PM, Wang Weijun wrote:
>>> Then why not fix the 2 bugs in a single changeset?
>>>
>> Both need spec update approval.  As they are completely different spec
>> update, better to update in 2 enhancements.
>>
>> As you have concerns here, I removed ObjectIdentifier.java from this
>> update.  See the new webrev:
>>
>>    http://cr.openjdk.java.net/~xuelei/8152237/webrev.01/
> Looks good to me.
>
> --Max
>
>> Xuelei




More information about the core-libs-dev mailing list