RFR 8150840: Add an internal system property to control the default level of System.Logger when java.logging is not present.
Mandy Chung
mandy.chung at oracle.com
Fri Mar 25 14:57:08 UTC 2016
> On Mar 25, 2016, at 5:12 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>
> On 24/03/16 18:56, Daniel Fuchs wrote:
>>> getSimpleFormat should probably check the given key argument is either
>>> DEFAULT_FORMAT_PROP_KEY or JUL_FORMAT_PROP_KEY; otherwise throws IAE.
>>> Otherwise, this method would pass if key is unexpected key if security
>>> manager is absent but fails if security manager is present.
>>
>> Oh - right - good idea. Replace the limited doPrivileged with
>> explicit argument checking :-) Let's do that.
>>
>
> Here is the new webrev:
>
> http://cr.openjdk.java.net/~dfuchs/webrev_8150840/webrev.03/index.html
>
> Only changes are in SimpleConsoleLogger.Formatting::getSimpleFormat.
Looks okay. Minor nit: why not using String::equals? No need to have a new webrev.
Mandy
More information about the core-libs-dev
mailing list