RFR: 8079136: Accessing a nested sublist leads to StackOverflowError

[Paul Sandoz]

> On 30 Mar 2016, at 11:03, Tagir F. Valeev <amaembo at gmail.com> wrote:
> 
> Hello!
> 
> IG> After the fix for JDK-8148748 went in, I needed to rebase the fix.
> IG> Comparing to the previous webrev, the changes are local to
> IG> ArrayList.spliterator().
> 
> IG> http://cr.openjdk.java.net/~igerasim/8079136/09/webrev/
> 
> IG> The builds/tests are green.
> 
> Looks good to me, thanks.
> 
> By the way I just noted that Paul pushed not the latest patch I
> prepared for 8148748. There are purely cosmetic differences missing:
> 

Ooops, i am sorry, i took r2 instead of r3.


> Couple of explanation comments here
> http://cr.openjdk.java.net/~tvaleev/webrev/8148748/r3/src/java.base/share/classes/java/util/ArrayList.java.html
> (lines 1285, 1286, 1303)
> 
> Additional test in SpliteratorTraversingAndSplittingTest:
> http://cr.openjdk.java.net/~tvaleev/webrev/8148748/r3/test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java.udiff.html
> 

> These changes were suggested by Paul here:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-March/039276.html
> 
> I don't know what's better alternative here:
> 
> 1. Drop these changes as they are not very important.
> 2. Log a separate issue for them.
> 3. Ask Ivan to add them to 8079136 (at least comments) as they belong
> to the same class.
> 
> What do you think?
> 

I think they are important, more so the test update.

If we can roll ‘em to Ivan’s patch that would be the most efficient. Ivan are you ok with that?

Paul.


> With best regards,
> Tagir Valeev.
> 
> IG> With kind regards,
> IG> Ivan