RFR:JDK-8148849:Truncating Duration

Stephen Colebourne scolebourne at joda.org
Wed Mar 30 13:33:53 UTC 2016


Yes, that looks OK now.
thanks
Stephen


On 30 March 2016 at 12:25, nadeesh tv <nadeesh.tv at oracle.com> wrote:
>
> Hi Stephen,
>
> Thanks for the comments.
> Please see the updated webrev
> http://cr.openjdk.java.net/~ntv/8148849/webrev.01/
>
> Made a change in unit == ChronoUnit.SECONDS  also
>
>
> Regards,
> Nadeesh TV
>
>
> On 3/29/2016 6:10 PM, Stephen Colebourne wrote:
>>
>> We're almost there, but looking at the tests, it looks like the
>> behaviour is wrong:
>>
>> The intended behaviour is that
>> -20.5mins (minus 20 minutes 30 secs) should truncate to -20mins
>> -2.1secs truncate to -2secs
>>
>> Note that the truncation is different to Instant here.
>> An Instant truncates towards the far past - like RoundingMode.FLOOR
>> A Duration truncates towards the zero - like RoundingMode.DOWN
>>
>> Stephen
>>
>>
>> On 29 March 2016 at 13:18, nadeesh tv <nadeesh.tv at oracle.com> wrote:
>>>
>>> Hi all,
>>>
>>> Bug Id : https://bugs.openjdk.java.net/browse/JDK-8148849
>>>
>>> Enhanced Duration by adding   public Duration truncatedTo(TemporalUnit
>>> unit)
>>>
>>> Please http://cr.openjdk.java.net/~ntv/8148849/webrev.00/
>>>
>>> --
>>> Thanks and Regards,
>>> Nadeesh TV
>>>
>
> --
> Thanks and Regards,
> Nadeesh TV
>



More information about the core-libs-dev mailing list