RFR: 8151542: URL resources for multi-release jar files have a #runtime fragment appended to them

Steve Drach steve.drach at oracle.com
Mon May 2 16:23:10 UTC 2016


Another webrev:  http://cr.openjdk.java.net/~sdrach/8151542/webrev.05/index.html <http://cr.openjdk.java.net/~sdrach/8151542/webrev.05/index.html>

Only URLClassPath has changed.  I put a comment on url.getProtocol indicating the URL assures it’s lower case and I changed the long lines into multiple shorter lines.

> Also, it may be worth considering an overloaded JarLoader constructor
> that accepts a “jar:” URL, rather than stripping and wrapping.

I tried that this morning.  There aren’t any “good” constructors for URL that have a jarHandler that I can use.  The ones I found do much more work than
what we are doing.

> 
> Also, some jar URLs will now go through JarLoader that previously didn’t.
> I’m not saying that this wrong, just trying to understand the behavioural 
> change. For example, some URLs that previously didn’t have their jar index
> checked now will.
> 
> I’ve been looking at this code, for another reason, sorry you have had to
> deal with it, it’s a bit of a mess.

It is indeed a bit of a mess


>  We may need to revisit some of this when
> 8155770 is resolved.
> 
> -Chris.
> 
> 
> 




More information about the core-libs-dev mailing list