RFR: 8139982 Re-examine java.management dependency on java.util.logging.LoggingMXBean

Mandy Chung mandy.chung at oracle.com
Mon May 2 18:06:48 UTC 2016


> On May 2, 2016, at 10:59 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Mandy,
> 
> I applied the suggested changes.
> 
> http://cr.openjdk.java.net/~dfuchs/8139982_webrev/webrev.08/index.html
> 

Looks very good and much cleaner.  Nits:

 166     // The LoggingMXBeanSupport class uses reflection to determine

s/LoggingMXBeanSupport/LoggingMXBeanAccess/

Also renaming the variable name “support” to “loggingAccess” (or something like that) might help.

You can fix it up before you push.  No need to generate a new webrev.

Mandy




More information about the core-libs-dev mailing list