Review request: 8154190 & 8155513: Deprivilege java.compiler and jdk.charsets

Mandy Chung mandy.chung at oracle.com
Tue May 3 20:16:45 UTC 2016


> On Apr 29, 2016, at 11:25 PM, Alan Bateman <alan.bateman at oracle.com> wrote:
> 
> On 30/04/2016 06:02, Mandy Chung wrote:
>> JDK-8154190: Deprivilege java.compiler module
>> Webrev:
>>    http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8154190/webrev.00/
>> 
>> JDK-8155513: Deprivilege jdk.charsets module
>> Webrev:
>>   http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8155513/webrev.00/
>> 
>> Very simple change.
>> 
>> These patches move java.compiler and jdk.charsets module to be defined by the platform class loader and grant with AllPermissions initially.  We could grant finer-grained permissions in the future.
>> 
> This looks okay to me. For jdk.charsets then I expect it should be easy to identify the permission it needs as there are only a few cases where it needs os.name or to read a resource file in the image.


I originally asked Sherman to identify the permissions for jdk.charsets as a follow up issue.  I took another look and define the list:
   http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8155513/webrev.01/

Mandy


More information about the core-libs-dev mailing list