RFR 8155088, Fix module dependencies in java/sql/* and javax/* tests

Felix Yang felix.yang at oracle.com
Mon May 9 15:29:25 UTC 2016


Hi Alan,

    updated the fix. Divide into two webrevs for 
https://bugs.openjdk.java.net/browse/CODETOOLS-7901671

Webrevs:

http://cr.openjdk.java.net/~xiaofeya/8155088/webrev.02_se/

http://cr.openjdk.java.net/~xiaofeya/8155088/webrev.02_ee/

I suggest to push the first one currently. And file another issue to 
track latter one. Because without fix for CODETOOLS-7901671( in next 
jtreg promotion ), those tests with EE modules in @modules will be 
skipped by default.

Thanks,

Felix

On 2016/5/4 23:44, Felix Yang wrote:
> Hi Alan,
>
>
> On 2016/5/4 22:45, Alan Bateman wrote:
>>
>>
>> On 04/05/2016 15:39, Felix Yang wrote:
>>> Hi Alan,
>>>
>>>     please review the updated webrev. Reverted changes for those 
>>> tests with "-addmods".
>>>
>>> http://cr.openjdk.java.net/~xiaofeya/8155088/webrev.01/
>> For the javax.transaction test then don't you also add 
>> "java.transaction" in the @modules value? The rest looks fine.
> I'm a bit confused here. There is "-addmods java.transaction" for 
> @compile. Is it still necessary to declare in @modules?
> Actually, if add java.transaction in the @modules, the test will be 
> skipped by jtreg. Filed 
> https://bugs.openjdk.java.net/browse/CODETOOLS-7901671 for jtreg, 
> because it looks to be not a good practice for either situation.
>
> -Felix
>>
>> -Alan
>




More information about the core-libs-dev mailing list