RFR:JDK-8155823: Add date-time patterns 'v' and 'vvvv'

[Stephen Colebourne]

This line:
*   v       generic time-zone name      zone-name         Pacific
Standard Time; PT
should be
*   v       generic time-zone name      zone-name         Pacific Time; PT


Missing space before "false" at line 1226:

appendInternal(new ZoneTextPrinterParser(textStyle, preferredZones,false));


This code:
if (zone.getRules().getTransition(ldt) == null) {
  type = zone.getRules().isDaylightSavings(Instant.from(ldt)) ? DST : STD;
}
won't work. It needs to be:
if (zone.getRules().getTransition(ldt) == null) {
  type = zone.getRules().isDaylightSavings(ldt.atZone(zone).toInstant())
? DST : STD;
}

This suggests JDK-8154567 needs an additional test case.


In the parsing test case, the input should be "Pacific Time", not
"Pacific Standard Time"

thanks
Stephen




On 9 May 2016 at 17:35, nadeesh tv <nadeesh.tv at oracle.com> wrote:
>
> Hi all,
>
> Reposting  because subject line did  not follow the format.
>
> Bug Id : https://bugs.openjdk.java.net/browse/JDK-8155823
> Issue:   Add date-time patterns 'v' and 'vvvv'
> webrev: http://cr.openjdk.java.net/~ntv/8155823/webrev.03/
>
> This webrev also contain the fix of  related bug
> https://bugs.openjdk.java.net/browse/JDK-8154567 as part of this.
>
> Special thanks for Stephen for his help in writing the spec.
>
> --
> Thanks and Regards,
> Nadeesh TV
>