RFR (JAXP) JDK-8156513: Problem list javax/xml/jaxp/unittest/stream/FactoryFindTest.java

[Amy Lu]

On 5/10/16 12:31 PM, huizhe wang wrote:
> On 5/9/2016 7:16 PM, Amy Lu wrote:
>> On 5/10/16 6:36 AM, huizhe wang wrote:
>>> I assume this is an intermittent failure. It looks like the newly 
>>> added module tests were interfering with this test.
>> Hi, Joe
>>
>> If jdk/lib/stax.properties exist (created by FactoryFindTest.java), 
>> BasicModularXMLParserTest.java and LayerModularXMLParserTest.java 
>> will fail (reproducible).
>>
>> FactoryFindTest.java changes the "jdk" under testing, this is in 
>> question. If it have to do that, maybe could do change on a copy and 
>> testing the copied jdk. Or, at least, it should make sure to clean up 
>> the change.
>
> FactoryFindTest wasn't thread safe. It was fine / it would have 
> removed the properties file before the module tests were added. I 
> haven't observed such failures locally, or in JPRT testing, that's why 
> I was saying this is intermittent. I suspect the module tests were 
> trying to read the file, which prevented FactoryFindTest from deleting it.
>
> You may modify FactoryFindTest so that it runs in an isolated JDK, 
> unfortunately, that had issue as well (JDK-8147431). The other option 
> is to disable the particular test case within FactoryFindTest that 
> generated the file and leave it to the JCK.
>
> Thanks,
> Joe
Thank you Joe!
I added this to JDK-8156508 comment as suggestion on the fix.

Thanks,
Amy