JDK 9 RFR of 8130679: Writer/StringWriter.write methods do not specify index out bounds

Chris Hegarty chris.hegarty at oracle.com
Tue May 10 09:36:06 UTC 2016


On 10 May 2016, at 00:29, Brian Burkhalter <Brian.Burkhalter at oracle.com> wrote:

> Hi Roger,
> 
> So modified:
> 
> http://cr.openjdk.java.net/~bpb/8130679/webrev.01/

This looks good to me.

I have to admit that I reviewed the current wording in Reader.read, but on
reflection it would be better to update it to reflect this wording. But that is a 
separate, lower priority, issue.

-Chris.

> Thanks,
> 
> Brian
> 
> On May 9, 2016, at 2:56 PM, Roger Riggs <roger.riggs at oracle.com> wrote:
>> Yes, I think that works well.
>> 
>> On 5/9/16 5:15 PM, Brian Burkhalter wrote:
>>> 
>>> So do you think that this form for example:
>>> 
>>> (common prefix)
>>>     * @throws  IndexOutOfBoundsException
>>>     *          If {@code off} is negative, or {@code len} is negative,
>>>     *          or {@code off + len} is negative or greater than the length
> 




More information about the core-libs-dev mailing list