RFR [9] 8156661: Handful of typos in javadoc
Pavel Rappo
pavel.rappo at oracle.com
Tue May 10 14:31:39 UTC 2016
Sorry for the incorrect subject field.
Should've been
Re: JDK 9 RFR of 8130679: Writer/StringWriter.write methods do not specify index out bounds
> On 10 May 2016, at 15:28, Pavel Rappo <pavel.rappo at oracle.com> wrote:
>
> Hold it right there :-)
>
> There's an open issue about BufferedWriter
>
> https://bugs.openjdk.java.net/browse/JDK-8029804
>
> So in this case what we've added in the @throws for
> java.io.BufferedWriter#write(java.lang.String, int, int) directly contradicts
> what it states two paragraphs above, doesn't it?
>
> * <p> If the value of the {@code len} parameter is negative then no
> * characters are written. This is contrary to the specification of this
> * method in the {@linkplain java.io.Writer#write(java.lang.String,int,int)
> * superclass}, which requires that an {@link IndexOutOfBoundsException} be
> * thrown.
>
> That doesn't look good.
>
>> On 10 May 2016, at 15:15, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>>
>> Looks good, Reviewed,
>>
>> Roger
>>
>>
>> On 5/10/2016 9:32 AM, Ivan Gerasimov wrote:
>>> Thanks Pavel!
>>>
>>>
>>> On 10.05.2016 16:28, Pavel Rappo wrote:
>>>> Hi Ivan, Looks good!
>>>>
>>>> // I'm not an Reviewer.
>>>>
>>>>> On 10 May 2016, at 14:07, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
>>>>>
>>>>> Hello!
>>>>>
>>>>> A couple of dozens of typos has been collected, so it's time to fix them.
>>>>>
>>>>> Would you please help review this trivial fix?
>>>>>
>>>>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8156661
>>>>> WEBREV: http://cr.openjdk.java.net/~igerasim/8156661/00/webrev/
>>>>>
>>>>>
>>>>> With kind regards,
>>>>>
>>>>> Ivan
>>>>>
>>>>
>>>
>>
>
More information about the core-libs-dev
mailing list