RFR(xs): 8156810 remove redundant sentence in SecurityManager.checkMemberAccess doc

Joseph D. Darcy joe.darcy at oracle.com
Wed May 11 23:50:01 UTC 2016


Looks fine Stuart,

-Joe

On 5/11/2016 4:47 PM, Stuart Marks wrote:
> Hi all,
>
> Regarding this bug,
>
>     https://bugs.openjdk.java.net/browse/JDK-8156810
>
> I had recently "upgraded" the deprecation annotation of 
> SecurityManager.checkMemberAccess() to include forRemoval=true. [1] 
> [2] This included the addition of some text about removal in a future 
> version. Unfortunately the deprecation text now reads, in part,
>
>     This method will be changed in a future release to check the
>     permission java.security.AllPermission. This method is subject
>     to removal in a future version of Java SE.
>
> Obviously the first sentence is irrelevant now that we're going to 
> remove the method entirely.
>
> Please review diff appended below that removes the first sentence.
>
> Thanks,
>
> s'marks
>
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8145468
>
> [2] 
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-April/040192.html
>
>
>
> diff -r 5f4aff1d2242 
> src/java.base/share/classes/java/lang/SecurityManager.java
> --- a/src/java.base/share/classes/java/lang/SecurityManager.java Mon 
> May 09 18:11:02 2016 +0800
> +++ b/src/java.base/share/classes/java/lang/SecurityManager.java Wed 
> May 11 16:46:11 2016 -0700
> @@ -1627,8 +1627,7 @@
>       * @deprecated This method relies on the caller being at a stack 
> depth
>       *             of 4 which is error-prone and cannot be enforced 
> by the runtime.
>       *             Users of this method should instead invoke {@link 
> #checkPermission}
> -     *             directly.  This method will be changed in a future 
> release
> -     *             to check the permission {@code 
> java.security.AllPermission}.
> +     *             directly.
>       *             This method is subject to removal in a future 
> version of Java SE.
>       *
>       * @see java.lang.reflect.Member




More information about the core-libs-dev mailing list