RFR 8029891 : Deadlock detected in java/lang/ClassLoader/deadlock/GetResource.java - A Revival

Mandy Chung mandy.chung at oracle.com
Thu May 12 18:44:03 UTC 2016


Hi Brent,

> 
> A new webrev is here:
> http://cr.openjdk.java.net/~bchristi/8029891/webrev.4/

This patch looks good.

To help future readers to understand this, it may be better to move:
1152     private transient ConcurrentHashMap<Object, Object> map =
1153             new ConcurrentHashMap<>(8);

to the beginning and add a comment describing what are lock-free and what are synchronized (basically some part of your summary below).

Also a comment in Hashtable::defaultWriteHashtable and readHashtable methods to mention that they are overridden by Properties.

In the GetResource.java test, what is the reason taking out:
  73   URL u2 = Thread.currentThread().getContextClassLoader().getResource("sun/util/resources/CalendarData.class”);

Mandy




More information about the core-libs-dev mailing list