JDK 9 RFR of 8130679: Writer/StringWriter.write methods do not specify index out bounds

[Brian Burkhalter]

Hello,

I have a third version of the patch here:

http://cr.openjdk.java.net/~bpb/8130679/webrev.00/

This one I believe addresses all the inconsistencies including the one in https://bugs.openjdk.java.net/browse/JDK-8029804 at the expense of a slight weakening of the specification of the Writer.write({char[],String},int,int) methods, and matches the behavior of all the classes affected. I have tested it and inspected the code extensively.

Thanks,

Brian

On May 10, 2016, at 8:11 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> On May 10, 2016, at 8:03 AM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> 
>> Good catch, the javadoc needs to match the code and in this case the new language
>> does not match the code.  Some cases are harder to follow because they delegate
>> to other classes for copying.
> 
> I think I’ll drop BufferedWriter from this RFR and let Pavel handle it in 8029804.
> 
>> It may also be the case that since Writer.write(char[], off, len) is abstract, it cannot enforce the contract
>> consistently on all subclasses and something special will be needed for that javadoc.
> 
> I’ll see whether this needs changing before revving.