JDK 9 RFR of 8130679: Writer/StringWriter.write methods do not specify index out bounds

Pavel Rappo pavel.rappo at oracle.com
Fri May 13 18:25:10 UTC 2016


Brian,

This looks good! 

--------------------------------------------------------------------------------
Could you please fix this tiny typo in-place?

 145      * @throws  IOException  if the pipe is
 146      *          <a href=PipedOutputStream.html#BROKEN><code>broken</code>}</a>,
                                                                             ^^^
And one more thing. You've removed this `@see` indentation in Writer.java.
(Surprisingly enough, some views generated by webrev, e.g. sdiff, do not show
it!)

  36  * @see   BufferedWriter
  37  * @see   CharArrayWriter
  38  * @see   FilterWriter
  39  * @see   OutputStreamWriter
> 40  * @see     FileWriter
  41  * @see   PipedWriter
  42  * @see   PrintWriter
  43  * @see   StringWriter
  44  * @see Reader

I believe it was intentional. It's a cute way to show the tree of inheritance.
Compare it with java.io.Reader:

      * @see BufferedReader
      * @see   LineNumberReader
      * @see CharArrayReader
      * @see InputStreamReader
      * @see   FileReader
      * @see FilterReader
      * @see   PushbackReader
      * @see PipedReader
      * @see StringReader
      * @see Writer

Thanks.

> On 13 May 2016, at 19:04, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> Correction: wrong link provided below:
> 
> http://cr.openjdk.java.net/~bpb/8130679/webrev.02/
> 
> Sorry for the confusion.
> 
> Brian
> 
> On May 13, 2016, at 10:42 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
>> I have a third version of the patch here:
>> 
>> http://cr.openjdk.java.net/~bpb/8130679/webrev.00/
>> 
>> This one I believe addresses all the inconsistencies including the one in https://bugs.openjdk.java.net/browse/JDK-8029804 at the expense of a slight weakening of the specification of the Writer.write({char[],String},int,int) methods, and matches the behavior of all the classes affected. I have tested it and inspected the code extensively.
> 




More information about the core-libs-dev mailing list