JDK 9 RFR of 8130679: Writer/StringWriter.write methods do not specify index out bounds
Roger Riggs
Roger.Riggs at Oracle.com
Fri May 13 18:44:00 UTC 2016
Hi Brian,
Looks fine. Thanks for digging through all the cases.
The @see indenting is ok, but not really a thing. White space is should
not be used/relied upon for formatting.
Roger
On 5/13/2016 2:34 PM, Brian Burkhalter wrote:
> Hi Pavel,
>
> On May 13, 2016, at 11:25 AM, Pavel Rappo <pavel.rappo at oracle.com> wrote:
>
>> This looks good!
> Good good! Thanks!
>
>> --------------------------------------------------------------------------------
>> Could you please fix this tiny typo in-place?
>>
>> 145 * @throws IOException if the pipe is
>> 146 * <a href=PipedOutputStream.html#BROKEN><code>broken</code>}</a>,
>> ^^^
> OK
>
>> And one more thing. You've removed this `@see` indentation in Writer.java.
>> (Surprisingly enough, some views generated by webrev, e.g. sdiff, do not show
>> it!)
>>
>> 36 * @see BufferedWriter
>> 37 * @see CharArrayWriter
>> 38 * @see FilterWriter
>> 39 * @see OutputStreamWriter
>>> 40 * @see FileWriter
>> 41 * @see PipedWriter
>> 42 * @see PrintWriter
>> 43 * @see StringWriter
>> 44 * @see Reader
>>
>> I believe it was intentional. It's a cute way to show the tree of inheritance.
>> Compare it with java.io.Reader:
>>
>> * @see BufferedReader
>> * @see LineNumberReader
>> * @see CharArrayReader
>> * @see InputStreamReader
>> * @see FileReader
>> * @see FilterReader
>> * @see PushbackReader
>> * @see PipedReader
>> * @see StringReader
>> * @see Writer
> That cuteness was lost on me; I’ll reinstate it.
>
> Brian
More information about the core-libs-dev
mailing list