RFR: 8147588: Jar file and Zip file not removed in spite of the OPEN_DELETE flag

[Alan Bateman]

On 15/05/2016 19:54, Xueming Shen wrote:
> Thanks Alan,
>
> Here is the webrev with the first proposed change.
>
> http://cr.openjdk.java.net/~sherman/8147588/webrev/
>
> -sherman
>
It needs a bit of clean-up but I think we can live with the approach.

One thing that could be cleaned up is to move the loading of RAF to 
SharedSecrets.getJavaIORandomAccessFileAccess using ensuredInitialized.

Another suggestion is to rename to newRandomAccess with the 3 parameters 
as a flags parameter to allow additional flags be passed in. This would 
allow the ZipFile.Source change to be simply:

String flags = (toDelete) ? "t" : "";
this.zfile = SharedSecrets.getJavaIORandomAccessFileAccess()
     .newRandomAccessFile(key.file, mode, flags);

It would need isWindows and so would be a lot cleaner (I think).

-Alan