RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode
shilpi.rastogi at oracle.com
shilpi.rastogi at oracle.com
Tue May 17 17:14:36 UTC 2016
On 5/17/2016 10:28 PM, Vladimir Ivanov wrote:
>> Could someone please explain why it is not required for this test as i
>> saw we are updating other tests (
>> http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/0e2a2be60453 ) ?
> The test was fixed in Jigsaw repo [1] in a different way.
>
> Before the fix, the test class should be put on boot class path (hence
> main/bootclasspath), since MethodHandles.Lookup.IMPL_LOOKUP was used.
>
> After the fix, MethodHandleHelper is part of java.base module and the
> test fetches the lookup from it:
>
> * @compile/module=java.base java/lang/invoke/MethodHandleHelper.java
> * @run main/othervm -esa CustomizedLambdaFormTest
> ...
> MethodHandle mh =
> MethodHandleHelper.IMPL_LOOKUP.findVirtual(String.class, "concat",
>
> So, main/othervm is enough and there's no need in
> main/bootclasspath/othervm anymore.
>
> Hope it helps.
Thank You Vladimir!
>
> Best regards,
> Vladimir Ivanov
>
> [1]
> http://hg.openjdk.java.net/jdk9/dev/jdk/diff/b2a69d66dc65/test/java/lang/invoke/CustomizedLambdaFormTest.java
More information about the core-libs-dev
mailing list