RFR (JAXP) 8156845: Uri is getting incorrectly unwrapped
Lance Andersen
lance.andersen at oracle.com
Tue May 17 20:23:43 UTC 2016
Ok to push joe
> On May 17, 2016, at 3:37 PM, huizhe wang <huizhe.wang at oracle.com> wrote:
>
> Thanks Lance!
>
> On 5/17/2016 11:26 AM, Lance Andersen wrote:
>> Hi Joe
>>
>> It looks OK. The formatting is a bit off where you encased existing code with new if statements so I would consider fixing that before you push
>
> It seems it has something to do with whitespaces. I re-generated the webrev. Also, I was missing a new file "uri.xml" in the webrev.
>
> http://cr.openjdk.java.net/~joehw/jdk9/8156845/webrev/ <http://cr.openjdk.java.net/~joehw/jdk9/8156845/webrev/>
>
> Best,
> Joe
>
>>
>> Best
>> Lance
>>> On May 17, 2016, at 12:42 PM, huizhe wang <huizhe.wang at oracle.com <mailto:huizhe.wang at oracle.com>> wrote:
>>>
>>> Hi,
>>>
>>> This patch fixes a missing feature in CatalogUriResolver where an uri entry can be referenced by a publicid (urn:publicid), similar to that of the public entry. The fix then is basically sharing the process for a public entry.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8156845 <https://bugs.openjdk.java.net/browse/JDK-8156845>
>>> webrev: http://cr.openjdk.java.net/~joehw/jdk9/8156845/webrev/ <http://cr.openjdk.java.net/%7Ejoehw/jdk9/8156845/webrev/>
>>>
>>> Thanks,
>>> Joe
>>
>> <Mail Attachment.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>
>>
>>
>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
More information about the core-libs-dev
mailing list