RFR: 8156807: Pack200 must support v53.0 class files

Aleksey Shipilev aleksey.shipilev at oracle.com
Wed May 18 16:10:52 UTC 2016


On 05/18/2016 05:20 PM, Kumar Srinivasan wrote:
> The second part is fixing up the test, which does not read the
> process streams correctly and causes a test hang, simplified
> the test with time tested utilities.
> 
> http://cr.openjdk.java.net/~ksrini/8156807/webrev.00/

A very minor snag in Constants.java:

  41     /*
  42         Java Class Version numbers history
  43         1.0 to 1.3.X 45,3
  44         1.4 to 1.4.X 46,0
  45         1.5 to 1.5.X 49,0
  46         1.6 to 1.6.X 50,0
  47         1.7 to 1.7.X 51,0
  48         1.8 to 1.8.X 52,0
  49         1.9 to 1.9.X 53.0
  50     */

Should be "53,0"? Notice the comma. Fix as you deem appropriate, no need
for re-review.

Otherwise looks good.

Thanks,
-Aleksey




More information about the core-libs-dev mailing list