RFR 8156718: Need tests for IsoFields getFrom for unsupported non-Iso Temporal fields
Bhanu Gopularam
bhanu.prakash.gopularam at oracle.com
Thu May 19 10:34:46 UTC 2016
Thank you Nadeesh and Stephen.
Here is the updated webrev link:
http://cr.openjdk.java.net/~bgopularam/JDK-8156718/webrev.01
Please review.
Bhanu
-----Original Message-----
From: Stephen Colebourne [mailto:scolebourne at joda.org]
Sent: Tuesday, May 17, 2016 5:11 PM
To: core-libs-dev
Subject: Re: RFR 8156718: Need tests for IsoFields getFrom for unsupported non-Iso Temporal fields
I would also like to see the test case methods be named "getFrom" not "getfrom".
Stephen
On 17 May 2016 at 05:18, nadeesh tv <nadeesh.tv at oracle.com> wrote:
> Hi Bhanu,
>
> I think you should add a test case comparing the return value of
> getFrom()
>
> ( Not an official reviewer)
>
> Regards,
> Nadeesh
>
> On 5/16/2016 11:46 AM, Bhanu Gopularam wrote:
>>
>> Hi all,
>>
>> Could you please review fix for following issue.
>>
>> Bug id: https://bugs.openjdk.java.net/browse/JDK-8156718
>>
>> Solution: Added tck tests for validating getFrom method for
>> unsupported non-Iso temporal fields
>>
>> Webrev: http://cr.openjdk.java.net/~bgopularam/JDK-8156718/webrev.00/
>>
>> Thanks,
>> Bhanu
>
>
> --
> Thanks and Regards,
> Nadeesh TV
>
More information about the core-libs-dev
mailing list