RFR 8156718: Need tests for IsoFields getFrom for unsupported non-Iso Temporal fields

[Roger Riggs]

Hi Bhanu,

Can you remind me why the value from line: 459

field.rangeRefinedBy(LocalDate.now());

is not checked also?  Is looks odd to see a value passed to a test and 
not have it verified.

It would need to use a fixed date (the same), but that is fine for that 
test.

Thanks, Roger

On 5/19/2016 7:16 AM, Stephen Colebourne wrote:
> Fine by me
> Stephen
>
> On 19 May 2016 at 11:34, Bhanu Gopularam
> <bhanu.prakash.gopularam at oracle.com> wrote:
>> Thank you Nadeesh and Stephen.
>>
>> Here is the updated webrev link:
>> http://cr.openjdk.java.net/~bgopularam/JDK-8156718/webrev.01
>>
>> Please review.
>>
>> Bhanu
>>
>> -----Original Message-----
>> From: Stephen Colebourne [mailto:scolebourne at joda.org]
>> Sent: Tuesday, May 17, 2016 5:11 PM
>> To: core-libs-dev
>> Subject: Re: RFR 8156718: Need tests for IsoFields getFrom for unsupported non-Iso Temporal fields
>>
>> I would also like to see the test case methods be named "getFrom" not "getfrom".
>>
>> Stephen
>>
>> On 17 May 2016 at 05:18, nadeesh tv <nadeesh.tv at oracle.com> wrote:
>>> Hi Bhanu,
>>>
>>> I think you should add a test case comparing the return value of
>>> getFrom()
>>>
>>>     ( Not an official reviewer)
>>>
>>> Regards,
>>> Nadeesh
>>>
>>> On 5/16/2016 11:46 AM, Bhanu Gopularam wrote:
>>>> Hi all,
>>>>
>>>> Could you please review fix for following issue.
>>>>
>>>> Bug id: https://bugs.openjdk.java.net/browse/JDK-8156718
>>>>
>>>> Solution: Added tck tests for validating getFrom method for
>>>> unsupported non-Iso temporal fields
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~bgopularam/JDK-8156718/webrev.00/
>>>>
>>>> Thanks,
>>>> Bhanu
>>>
>>> --
>>> Thanks and Regards,
>>> Nadeesh TV
>>>