Review Request: 8157391: jdeps left JarFile open

Alan Bateman Alan.Bateman at oracle.com
Fri May 20 06:39:07 UTC 2016



On 20/05/2016 04:55, Mandy Chung wrote:
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157391/webrev.00/index.html
>
> tools/jdeps/modules/GenModuleInfo.java
> tools/jdeps/modules/TransitiveDeps.java
> tools/jdeps/modules/InverseDeps.java
>
> These tests still failed on windows after JDK-8152502.
>
> Now I have the jtreg logs showing that JAR files can’t be deleted although I still can’t reproduce them locally and on JPRT (will find out what’s the difference tomorrow).
>
This looks okay to me. One thing you could do in the test is have 
JdepsUtil.Command be Closeable so that the tests can use 
try-with-resources and avoid failing with a file open.

-Alan.



More information about the core-libs-dev mailing list