[PATCH] Implement a noop clear() for Collections#EMPTY_LIST

David Holmes david.holmes at oracle.com
Mon May 23 11:25:57 UTC 2016


On 23/05/2016 8:43 PM, Paul Sandoz wrote:
> Hi Naufal,
>
> Thanks for looking at this.
>
> For us to accept your patch (no matter how small) you need to become a contributor, which requires that you agree to the Oracle Contributor Agreement (OCA), see:
>
>   http://openjdk.java.net/contribute/

Simple patches can be accepted without an OCA

http://openjdk.java.net/bylaws#participant

Cheers,
David

> Thanks,
> Paul.
>
>> On 22 May 2016, at 12:10, Mohamed Naufal <naufal11 at gmail.com> wrote:
>>
>> Hi,
>>
>> A call to clear() on Collections#EMPTY_LIST is currently redirected to
>> AbstractList#clear(), which performs a bunch of checks and creates a
>> ListItr object, all of which is unnecessary for an EmptyList.
>>
>> PFA a patch that implements a noop clear() for EmptyList.
>>
>> Thanks,
>> Naufal
>> <EmptyList_clear.diff>
>



More information about the core-libs-dev mailing list