RFR: JDK-8153768 Miscellaneous changes imported from jsr166 CVS 2016-05

[Paul Sandoz]

> On 24 May 2016, at 01:03, Martin Buchholz <martinrb at google.com> wrote:
> 
> On Mon, May 23, 2016 at 3:29 PM, Aleksey Shipilev
> <aleksey.shipilev at oracle.com> wrote:
>> On 05/23/2016 11:32 PM, Martin Buchholz wrote:
>>> JSR166 CVS has some unfinished work in progress, but enough minor
>>> changes have accumulated that we should integrate into openjdk9:
>>> 
>>> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/miscellaneous/
>> 

+1


>> *) Removing Cloneable from submaps probably requires CCC?
> 
> It never appears in the API.

Yes, cannot write Java source to call clone on the returned ConcurrentNavigableMap, so i think we are ok here.

Paul.

> The use of Cloneable here was a mistake
> - the clone method was never implemented!  So only users who checked
> for "implements Cloneable" without actually trying to call clone could
> be affected.  And who would try to clone submaps anyways?
> 
>> *) Want to be extra modern in sample code? Use method references!
>>    - *   solvers.forEach((solver) -> cs.submit(solver));
>>    + *   solvers.forEach(cs::submit);
> 
> OK - switched to using method references!