8157677: Subclasses of Reader do not inherit the contents in the exception tag from the parent Reader class in the latest spec
Roger Riggs
roger.riggs at oracle.com
Tue May 24 14:36:28 UTC 2016
Hi Pavel,
To keep it simple and clean, the change from @exception to @throws is
not needed
and reduces the number of files changed.
The change in the parameter name is a bit unusual, typically they are
not changed
but in this case the change is needed to make parameter name consistent with
the *inherited* specification.
The change of @exception to @throws can be done consistently across the
file later.
$.02, Roger
On 5/24/16 10:24 AM, Pavel Rappo wrote:
> Thanks for looking at this!
>
>> On 24 May 2016, at 15:16, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
>>
>> *) CharArrayReader: code changes
> What's your concern with 'b'->'buf' rename? Access parameter's name through
> reflection or something else?
>
>> *) It's weird to see @exception and @throws side-by-side:
>>
>> * @exception IOException If an I/O error occurs
>> * @throws IndexOutOfBoundsException {@inheritDoc}
>>
> I wanted to address this issue only, i.e. to be very focused.
>
>> Wouldn't it be better to raise the priority for the javadoc bug, and fix
>> it there?
> It doesn't mean we can't raise the priority, though it's not me to decide this.
> Especially, given there's a trivial workaround available.
>
>
More information about the core-libs-dev
mailing list