RFR: 8157716: jdk.internal.loader.ClassLoaders.addURLToUCP() should return converted real path URL

Martin Buchholz martinrb at google.com
Tue May 24 17:57:44 UTC 2016


English syntax error.

+     * Attempts to convert to the given string to a file URL.

---

There should be some motivation for why you are calling toRealPath,
and e.g. not toAbsolutePath.
What problem are you trying to solve?

At Google we have special needs - this is the kind of change we end up
locally reverting.


On Tue, May 24, 2016 at 10:47 AM, Jiangli Zhou <jiangli.zhou at oracle.com> wrote:
> Hi,
>
> Please review the following webrev that changes the jdk.internal.loader.ClassLoaders.addURLToUCP() to java.internal.loader.ClassLoaders.toFileURL(). The change is provided by Alan (thanks, Alan!).
>
> webrev: http://cr.openjdk.java.net/~jiangli/8157716/webrev.00/
> but: https://bugs.openjdk.java.net/browse/JDK-8157716
>
> Thanks,
> Jiangli
>
>



More information about the core-libs-dev mailing list