8157677: Subclasses of Reader do not inherit the contents in the exception tag from the parent Reader class in the latest spec

Aleksey Shipilev aleksey.shipilev at oracle.com
Wed May 25 09:21:19 UTC 2016


On 05/24/2016 05:24 PM, Pavel Rappo wrote:
> Thanks for looking at this!
> 
>> On 24 May 2016, at 15:16, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
>>
>> *) CharArrayReader: code changes
> 
> What's your concern with 'b'->'buf' rename? Access parameter's name through
> reflection or something else?

This change is not covered by bug synopsis. This forces to read every
damn changeset when traversing the change history for a file, looking
for suspicious changes.


>> *) It's weird to see @exception and @throws side-by-side:
>>
>>      * @exception  IOException  If an I/O error occurs
>>      * @throws     IndexOutOfBoundsException {@inheritDoc}
>>
> 
> I wanted to address this issue only, i.e. to be very focused. 

This desire contradicts with the 'b' -> 'buf' change.

>> Wouldn't it be better to raise the priority for the javadoc bug, and fix
>> it there?
> 
> It doesn't mean we can't raise the priority, though it's not me to decide this.
> Especially, given there's a trivial workaround available.

It's your call, but I am very unhappy seeing JDK code changes to work
around the bug in the JDK tool that we have the developers for.

Thanks,
-Aleksey




More information about the core-libs-dev mailing list