RFR: 8157716: jdk.internal.loader.ClassLoaders.addURLToUCP() should return converted real path URL
Jiangli Zhou
jiangli.zhou at oracle.com
Wed May 25 21:07:14 UTC 2016
Hi Alan and Mandy,
Thanks for confirming that.
Thanks,
Jiangli
> On May 25, 2016, at 12:39 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>
>
>> On May 25, 2016, at 12:24 PM, Jiangli Zhou <jiangli.zhou at oracle.com> wrote:
>>
>> Hi Mandy,
>>
>>> On May 25, 2016, at 12:17 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>>
>>>
>>>> On May 25, 2016, at 11:28 AM, Jiangli Zhou <jiangli.zhou at oracle.com> wrote:
>>>>
>>>> Here is the updated webrev:
>>>>
>>>> http://cr.openjdk.java.net/~jiangli/8157716/webrev.01/
>>>
>>> The version restoring toRealPath looks okay.
>>
>> Thanks for the review.
>>
>>>
>>> I think the proposed toFileURL method name is fine and perhaps the javadoc of toFileURL method could make it clearer. If we had to rename it, maybe toRealPathFileURL (mouthful but it clearly shows it’s “real path” as specified in java.nio.file.Path).
>>
>> I discussed with Alan. We will keep the proposed toFileURL method name for now.
>
> That’s fine with me.
>
> Mandy
>
More information about the core-libs-dev
mailing list