Review Request JDK-8152721: Java Web Start splash mechanism is not working in JDK9
Mandy Chung
mandy.chung at oracle.com
Tue May 31 02:59:01 UTC 2016
> On May 27, 2016, at 9:54 PM, Alan Bateman <alan.bateman at oracle.com> wrote:
>
> On 28/05/2016 05:29, Mandy Chung wrote:
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8152721/webrev.00/
>>
>> The launcher does not handle the new options with whitespace separated arguments properly. This patch applies that consistently in java.c I leave arg.c as is that Kumar/Henry can consider cleanup in the future.
>>
> The new options are handled correctly on the command, I think it's just the JDK internal JLI_Launch entry point where this was missed. The patch looks okay, I just wonder if there is there are any tests that could use this entry point.
SelectVersion is called for launching any application. It processes -splash option separately from the launcher argument processing. To hit this bug, it will need to launch with the new module-system option together with -splash. I have verified with my modified version of a client test verifying the -splash option.
I prefer to file a JBS issue for the client team to create a test for this if that’s okay with you.
Mandy
More information about the core-libs-dev
mailing list