RFR(s): 8169055: [TESTBUG] : java/io/Serializable/serialFilter/ tests have undeclared dependency on jdk.jdeps module

[Sergei Kovalev]

Hi Mandy,

Thank you. This really helpful.

-- 
With best regards,
Sergei

02.11.16 21:05, Mandy Chung wrote:
> jdeps now has a new option [1] to make it easy to analyze the test dependency;
>      —-list-deps and —-list-reduced-deps
>
> $ jdeps --list-deps -cp testng.jar JTwork/classes/java/io/Serializable/serialFilter/
>
>     java.base
>     java.compiler
>     unnamed module: testng.jar
>
> This will also list internal APIs if referenced in the form for @modules consumption.
>
> Mandy
> [1] https://bugs.openjdk.java.net/browse/JDK-8167057
>
>> On Nov 2, 2016, at 10:39 AM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>>
>> Hi,
>>
>> I would rather switch the test to use a type in the base module.
>> Switching from SourceVersion to javax.net.ssl.SSLEngineResult enables the test to run
>> without additional @modules.
>>
>> Webrev/patch:
>> http://cr.openjdk.java.net/~rriggs/webrev-filter-classes-8169055/
>>
>> Roger
>>
>>
>> On 11/2/2016 9:31 AM, Sergei Kovalev wrote:
>>> Thank you all,
>>>
>>> java.compiler is enough.
>>>
>>> http://cr.openjdk.java.net/~skovalev/8169055/webrev.02/
>>>
>>>
>>> 02.11.16 16:25, Daniel Fuchs wrote:
>>>> Hi Sergey,
>>>>
>>>> Why jdk.compiler? Why not simply java.compiler?
>>>>
>>>> best regards,
>>>>
>>>> -- daniel
>>>>
>>>> On 02/11/16 12:51, Sergei Kovalev wrote:
>>>>> Fixed
>>>>>
>>>>> http://cr.openjdk.java.net/~skovalev/8169055/webrev.01/
>>>>>
>>>>>
>>>>> 02.11.16 15:34, Chris Hegarty wrote:
>>>>>>> On 2 Nov 2016, at 12:31, Sergei Kovalev <sergei.kovalev at oracle.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>> javax.lang.model.SourceVersion
>>>>>> This type is in the java.compiler module.
>>>>>>
>>>>>> -Chris.