JDK 9 RFR of JDK-8037278: sun/rmi/runtime/Log/6409194/NoConsoleOutput.java fails Intermittently: unexpected subprocess output
Daniel Fuchs
daniel.fuchs at oracle.com
Thu Nov 3 13:35:15 UTC 2016
Hi Amy,
Looks good to me.
-- daniel
On 03/11/16 13:22, Amy Lu wrote:
> Thank you Daniel for your review.
>
> Yes, agree and reverted those three lines.
>
> webrev updated:
> http://cr.openjdk.java.net/~amlu/8037278/webrev.01
>
> Thanks,
> Amy
>
> On 11/3/16 8:37 PM, Daniel Fuchs wrote:
>> Hi Amy,
>>
>> I think it might still be useful to see what the subprocess
>> prints on System.out in case of failure.
>> I would leave lines 83, 86 and 87 unchanged.
>>
>> best regards,
>>
>> -- daniel
>>
>> On 03/11/16 11:58, Amy Lu wrote:
>>> Please review the patch for test
>>> sun/rmi/runtime/Log/6409194/NoConsoleOutput.java
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8037278
>>> webrev: http://cr.openjdk.java.net/~amlu/8037278/webrev.00/
>>>
>>> This test fails whenever there’s extra output from System.out (from the
>>> test application DoRMIStuff). But actually this test is for checking RMI
>>> logging messages and that are from System.err. Test should ignore the
>>> output from System.out.
>>>
>>> Thanks,
>>> Amy
>>
>
More information about the core-libs-dev
mailing list