RFR: jsr166 jdk9 integration wave 12

Martin Buchholz martinrb at google.com
Fri Nov 18 17:23:27 UTC 2016


Here's a few more places to apply Remi's rule:

--- src/test/tck/Collection8Test.java 15 Nov 2016 23:08:30 -0000 1.27
+++ src/test/tck/Collection8Test.java 18 Nov 2016 17:21:19 -0000
@@ -304,7 +304,7 @@
             switch (rnd.nextInt(4)) {
             case 0: survivors.addAll(c); break;
             case 1: survivors.addAll(Arrays.asList(c.toArray())); break;
-            case 2: c.forEach(e -> survivors.add(e)); break;
+            case 2: c.forEach(survivors::add); break;
             case 3: for (Object e : c) survivors.add(e); break;
             }
             assertTrue(orig.containsAll(accepts));
@@ -355,11 +355,11 @@
         ArrayList forEached = new ArrayList();
         ArrayList removeIfed = new ArrayList();
         for (Object x : c) iterated.add(x);
-        c.iterator().forEachRemaining(e ->
iteratedForEachRemaining.add(e));
+        c.iterator().forEachRemaining(iteratedForEachRemaining::add);
         for (Spliterator s = c.spliterator();
-             s.tryAdvance(e -> tryAdvanced.add(e)); ) {}
-        c.spliterator().forEachRemaining(e -> spliterated.add(e));
-        c.forEach(e -> forEached.add(e));
+             s.tryAdvance(tryAdvanced::add); ) {}
+        c.spliterator().forEachRemaining(spliterated::add);
+        c.forEach(forEached::add);
         c.removeIf(e -> { removeIfed.add(e); return false; });
         boolean ordered =
             c.spliterator().hasCharacteristics(Spliterator.ORDERED);
@@ -589,7 +589,7 @@
         try (PoolCleaner cleaner = cleaner(pool, done)) {
             threadsStarted.bulkRegister(tasks.size());
             futures = tasks.stream()
-                .map(task -> pool.submit(task))
+                .map(pool::submit)
                 .collect(Collectors.toList());
             threadsStarted.arriveAndDeregister();
             Thread.sleep(testDurationMillis);


More information about the core-libs-dev mailing list