[9] RFR: 8170120: Several new jimage testcases should be excluded due to their failures

Denis Kononenko denis.kononenko at oracle.com
Tue Nov 22 12:51:07 UTC 2016


  Hi,

Could someone please review this small fix.

Recently several failing test cases were delivered into jdk9-dev by my mistake (https://bugs.openjdk.java.net/browse/JDK-8167240). I've just renamed these test cases to temporarily avoid their execution. They should be renamed back when appropriate fixes for 4 product bugs are delivered.
Also I've fixed testcase JImageVerifyTest.testVerifyNotExistingImage, it contained a regrettable error and duplicated another test case (testVerifyImageNotSpecified).

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8170120
WEBREV: http://cr.openjdk.java.net/~dkononenko/8170120/webrev.00


Now the tests have 100% pass rate.

JImageListTest:

Invoking testList
jimage [list, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testListHelp
jimage [list, -h]
jimage [list, --help]
Invoking testListVerbose
jimage [list, --verbose, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testListIncludeAllWithGlob
jimage [list, /home/dnk/projects/oracle/jdk-9/lib/modules]
jimage [list, --include, **, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testListIncludeWithGlob
jimage [list, /home/dnk/projects/oracle/jdk-9/lib/modules]
jimage [list, --include, /java.base/java/util/zip/**, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testListIncludeNoMatchWithGlob
jimage [list, --include, not_matching, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testListIncludeAllWithExplicitGlob
jimage [list, /home/dnk/projects/oracle/jdk-9/lib/modules]
jimage [list, --include, glob:**, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testListIncludeAllWithRegex
jimage [list, /home/dnk/projects/oracle/jdk-9/lib/modules]
jimage [list, --include, regex:.*, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testListIncludeWithRegex
jimage [list, /home/dnk/projects/oracle/jdk-9/lib/modules]
jimage [list, --include, regex:/java.base/java/text/.*, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testListIncludeNoMatchWithRegex
jimage [list, --include, regex:not_matching, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testListIncludeMultiplePatterns
jimage [list, /home/dnk/projects/oracle/jdk-9/lib/modules]
jimage [list, --include, glob:/java.base/java/time/**,regex:/java.base/java/util/zip/.*, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testListNotExistingImage
jimage [list, ./not_existing_image]
Invoking testListWithUnknownOption
jimage [list, --unknown]
STDERR:
STATUS:Passed.


JImageExtractTest:

Invoking testExtract
jimage [extract, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testExtractHelp
jimage [extract, --help]
jimage [extract, --help]
Invoking testExtractToDir
jimage [extract, --dir, ./JImageExtractTest3092688479608335903, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testExtractNotExistingImage
jimage [extract, ./not_existing_image]
Invoking testExtractToUnspecifiedDir
jimage [extract, --dir, --, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testExtractToNotExistingDir
jimage [extract, --dir, ./JImageExtractTest9794403129293432977, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testExtractFromDir
jimage [extract, home/dnk/projects/oracle/jdk-9/lib]
Invoking testExtractToDirBySymlink
jimage [extract, --dir, ./symlink, /home/dnk/projects/oracle/jdk-9/lib/modules]
STDERR:
STATUS:Passed.


JImageVerifyTest:

Invoking testVerify
jimage [verify, /home/dnk/projects/oracle/jdk-9/lib/modules]
Invoking testVerifyHelp
jimage [verify, -h]
jimage [verify, --help]
Invoking testVerifyNotExistingImage
jimage [verify, ./not_existing_image]
Invoking testVerifyWithUnknownOption
jimage [verify, --unknown]
STDERR:
STATUS:Passed.

Also I need a sponsor to push the change into jdk9-dev.

  Thank you,
  Denis.




More information about the core-libs-dev mailing list