JDK 9 RFR of JDK-8169479: java.lang.reflect.Constructor class has wrong api documentation

Brian Burkhalter brian.burkhalter at oracle.com
Wed Nov 23 17:27:35 UTC 2016


+1

Brian

On Nov 23, 2016, at 9:25 AM, Paul Sandoz <paul.sandoz at oracle.com> wrote:

> +1
> 
> Paul.
> 
>> On 23 Nov 2016, at 08:10, joe darcy <joe.darcy at oracle.com> wrote:
>> 
>> Hello,
>> 
>> Please review the changes to address
>> 
>>   JDK-8169479: java.lang.reflect.Constructor class has wrong api documentation
>>   http://cr.openjdk.java.net/~darcy/8169479.0/
>> 
>> Patch inline below. There are a few issues reported in the bug:
>> 
>> * The Constructor.toString method fails to state it prints out "throws" information. The implementation already does this and the analogous methods Constructor.toGenericString, Method.toString, etc. explicitly mention throws information already.
>> 
>> * The specification of Executable.getDeclaringClass can be overridden to be more precise in the Constructor and Method subclasses.
>> 
>> * In Constructor.toGenericString, "return type" is used where "class name" is meant.
>> 
>> Thanks,
>> 
>> -Joe



More information about the core-libs-dev mailing list