RFR 8170408: LogGeneratedClassesTest.java fails with recent changes

[Daniel Fuchs]

On 29/11/16 13:33, Wang Weijun wrote:
> http://cr.openjdk.java.net/~weijun/8170408/webrev.01
>
> jdk_lang passes on all JPRT platforms.

Looks good to me Max!

best regards,

-- daniel

>
> Thanks
> Max
>
>> On Nov 29, 2016, at 9:26 PM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>>
>> Hi Max,
>>
>> On 29/11/16 12:30, Wang Weijun wrote:
>>> Maybe I should use
>>>
>>> (p, a) -> p.startsWith(Paths.get("dump/com/example"))
>>>        && a.isRegularFile()).count(),
>>
>> Yes - something like that.
>> But that was just a suggestion.
>>
>>>
>>> On Windows it's \.
>>
>> I remember I had some trouble getting the filter right.
>>
>> best regards,
>>
>> -- daniel
>>
>>>
>>> I'll run some test now.
>>>
>>> Thanks
>>> Max
>>>
>>>> On Nov 29, 2016, at 8:25 PM, Wang Weijun <weijun.wang at oracle.com> wrote:
>>>>
>>>> Like this?
>>>>
>>>>  (p, a) -> p.toString().startsWith("dump/com/example")
>>>>         && a.isRegularFile()).count(),
>>>>
>>>> Thanks
>>>> Max
>>>>
>>>>> On Nov 29, 2016, at 7:22 PM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>>>>>
>>>>> Hi Max,
>>>>>
>>>>> On 29/11/16 06:46, Wang Weijun wrote:
>>>>>> http://cr.openjdk.java.net/~weijun/8170408/webrev.00/
>>>>>>
>>>>>> A lambda inside JDK is dumped, we should not count it in this test.
>>>>>
>>>>> Looks good to me. An alternative might be to only look
>>>>> at the files under dump/com/example (I remember modifying
>>>>> LogGeneratedClassesTest::testLoggingException for exactly
>>>>> that same kind of reasons).
>>>>>
>>>>> best regards,
>>>>>
>>>>> -- daniel
>>>>>
>>>>>>
>>>>>> Thanks
>>>>>> Max
>>>>>>
>>>>>
>>>>
>>>
>>
>