RFR: 8159855

[forax at univ-mlv.fr]

It seems to be a little to JDK centric to me.

Rémi

----- Mail original -----
> De: "Alan Bateman" <Alan.Bateman at oracle.com>
> À: "Remi Forax" <forax at univ-mlv.fr>, "Jonathan Gibbons" <jonathan.gibbons at oracle.com>
> Cc: compiler-dev at openjdk.java.net, "OpenJDK Dev list" <core-libs-dev at openjdk.java.net>
> Envoyé: Mercredi 5 Octobre 2016 13:39:02
> Objet: Re: RFR: 8159855

> On 05/10/2016 12:10, Remi Forax wrote:
>> Very nice,
>> it will greatly help gradle, maven, etc.
>>
>> in com/sun/tools/javac/main/Main.java,
>> the other constructor should delegate its initialization to the constructor you
>> just add,
>>       public Main(String name, PrintWriter out) {
>>           this(name, out, out);
>>       }
>>
>> I wonder if findFirst() in ToolProvider should not take a ClassLoader as
>> parameter instead of being restricted to the system classloader.
>>
> The findFirst(tool) method just a convenience, the intention is that if
> you want to use other contexts then you just invoke ServiceLoader to
> locate it.
> 
> -Alan.