RFR: 8166460: jdk/internal/util/jar/TestVersionedStream gets Assertion error

Paul Sandoz paul.sandoz at oracle.com
Mon Oct 10 22:03:12 UTC 2016


> On 10 Oct 2016, at 14:50, Steve Drach <steve.drach at oracle.com> wrote:
> 
> As a consequence of some conversations about this test, I’ve removed the part that specifically depended on the order of the entries and now just verify that the order of the versioned entries is the same relative order as all the entries in the jar file.   The updated changeset is http://cr.openjdk.java.net/~sdrach/8166460/webrev.03/ <http://cr.openjdk.java.net/~sdrach/8166460/webrev.03/>
> 

This looks better (crossing fingers JPRT passes).

Thanks,
Paul.

>> On Oct 5, 2016, at 12:27 PM, Steve Drach <steve.drach at oracle.com> wrote:
>> 
>> Hi,
>> 
>> Please review the following changeset that creates a replacement for the TestVersionedStream test.  The previous test occasionally failed on Linux hotspot nightly testing due to jar tool sometimes changing the order of the entries.  The new test specifically sets the order of the entries and tests both possible orders.
>> 
>> issue: https://bugs.openjdk.java.net/browse/JDK-8166460 <https://bugs.openjdk.java.net/browse/JDK-8166460>
>> webrev: http://cr.openjdk.java.net/~sdrach/8166460/webrev.00/ <http://cr.openjdk.java.net/~sdrach/8166460/webrev.00/>
>> 
>> Thanks,
>> Steve
>> 
> 



More information about the core-libs-dev mailing list