RFR:JDK-8163330:HijrahDate aligned day of week incorrect

Stephen Colebourne scolebourne at joda.org
Wed Oct 12 11:00:05 UTC 2016


The indentation in TCKHijrahChronology is not correct.

In TCKHijrahChronology, it would be better to add the expected values
to the provider
ie two additional value for aligned week and aligned day:
{1437, 9, 1, 1, 1}
{1437, 9, 2, 1, 2}
...

That way, the test relies on facts, not on a formula.

Stephen



On 7 October 2016 at 09:42, Anubhav Meena <anubhav.meena at oracle.com> wrote:
> Hi all,
>
> Please review.
>
> Bug Id :  https://bugs.openjdk.java.net/browse/JDK-8163330
>
> Issue:  The HijrahDate class incorrectly calculates the aligned-day-of-week
> field. It based the calculation on the day-of-week, when it should be based
> on the day-of-month.
>
> Webrev: http://cr.openjdk.java.net/~rchamyal/anmeena/8163330/webrev.02/
>
> --
> Thanks and Regards,
>
> Anubhav


More information about the core-libs-dev mailing list