RFR: 8168073: Speed up URI creation during module bootstrap
Claes Redestad
claes.redestad at oracle.com
Mon Oct 17 18:45:04 UTC 2016
On 2016-10-17 20:07, Alan Bateman wrote:
>
>
> On 17/10/2016 12:17, Claes Redestad wrote:
>> Hi,
>>
>> one partial cause for startup regressions due to jigsaw is related to
>> creating
>> URIs for the location of each module.
>>
>> By providing a package-private constructor we can avoid the time to
>> scan and
>> validate the URI, which takes a little time (executes ~80K bytecodes)
>> but also
>> pushes various methods over compilation thresholds during early startup,
>> which more notably interferes with perceived startup.
>>
>> http://cr.openjdk.java.net/~redestad/8168073/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8168073
> This looks okay, I just wondering if JavaNetAccess should be renamed to
> JavaNetUriAccess to avoid it being used to access other classes in
> java.net. If renamed then I guess createUri could be renamed to create too.
Most other SharedSecrets classes seems to be per-package, so not sure
if this case is special enough to start making them per-class, other
than the slightly more natural naming.
/Claes
>
> -Alan
More information about the core-libs-dev
mailing list