RFR 8071588: The spec for javax.script.ScriptEngineFactory.getProgram() should specify NPEs thrown

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Wed Oct 19 07:55:22 UTC 2016


Hi Alan,

Thanks for your review. Yes, spec. change is being tracked. I'll remove 
that whitespace after doc comment of getProgram method and push it.

PS. Updated webrev for the record: 
http://cr.openjdk.java.net/~sundar/8071588/jdk/webrev.01/

Thanks,
-Sundar

On 19/10/16, 12:42 PM, Alan Bateman wrote:
> On 19/10/2016 06:06, Sundararajan Athijegannathan wrote:
>
>> Please review.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8071588
>>
>> jdk webrev: http://cr.openjdk.java.net/~sundar/8071588/jdk/webrev.00/
>>
>> nashorn webrev:
>> http://cr.openjdk.java.net/~sundar/8071588/nashorn/webrev.00/
>>
> This looks okay (except the spurious blank line after the class 
> comment). It's a spec change that will need to be tracked.
>
> -Alan


More information about the core-libs-dev mailing list