Review Request: JDK-8168205: Should not default class path to CWD if -cp is not specified but -m is specified

Paul Sandoz paul.sandoz at oracle.com
Thu Oct 27 19:24:18 UTC 2016


> On 26 Oct 2016, at 22:59, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> Webrev:
>   http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8168205/webrev.00/index.html
> 
> If -cp is not specified and -m is not specified, the builtin system
> class loader will default the class path to the current working
> directory.  If -m is specified, no -cp and CLASSPATH environment
> variable is not set, it should mean no class path.  This patch fixes
> the case if -m is specified and the value of java.class.path is empty,
> e.g. via -Djava.class.path option, then no class path should be set.
> 
> This patch also updates the launcher code used for generating launcher
> for JDK tools. As the JDK tool no longer passes any class path, it
> removes APP_CLASSPATH macro.
> 

+1

I would be inclined to separate out the test for whether JAVA_CLASS_PATH property is present from the class loading tests e.g. if you don’t pass any argument to the Main assert the property value is non-null, otherwise assert on loading a resource.

Paul.



More information about the core-libs-dev mailing list