Review Request: JDK-8167057 jdeps to list the modules and internal APIs to help find @modules for tests

[Mandy Chung]

> On Oct 28, 2016, at 3:03 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Mandy,
> 
> Looks good to me in general, but I feel like the new
> option --list-reduced-deps should be better documented:
> 

I agree and this details and example can be covered in the man page.

> jdeps.properties:
> 
> 152 main.opt.list-deps=\
> 153 \  --list-deps\n\
> 154 \  --list-reduced-deps           Lists the dependences and use of JDK internal\n\
> 155 \                                APIs. --list-reduced-deps lists the dependences\n\
> 156 \                                after transition reduction.
> 
> #1 - is it 'transition reduction' or 'transitive reduction'?
>     (at two places in this file: line 156 & line 135)
> 

Good catch.  typo should be “transitive” and will fix it.
  
> #2 - could the description be made a little more verbose? something
>     like:
> 
> --list-reduced-deps                   lists the dependences
>                                      after transitive reduction.
>                                      Transitive reduction is obtained
>                                      by removing the dependencies which
>                                      are already transitively exported
>                                      by another module in the
>                                      dependency graph. For instance,
>                                      if both java.sql and java.logging
>                                      are included in the dependency
>                                      graph, then java.logging will be
>                                      removed because it is already
>                                      transitively exported by
>                                      java.sql, and therefore
>                                      requiring java.sql should be
>                                      enough.

Good idea.  I will expand the description.

Mandy

> 
> 
> best regards,
> 
> -- daniel
> 
> 
> On 19/10/16 23:19, Mandy Chung wrote:
>> Webrev at:
>>  http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167057/webrev.00/
>> 
>> This patch enhances jdeps to print the dependences in the format : $MODULE[/$PACKAGE].
>> 
>> This is intended for analyzing the regression tests we develop and add make it easy to add the proper @modules.
>> 
>> Mandy
>> 
>